Welcome, Guest
Username: Password: Remember me
Espace réservé aux bonne idées et suggestions pour Joomlack.
  • Page:
  • 1

TOPIC: VM addToCart CK fix

VM addToCart CK fix 22 Jul 2020 15:00 #57258

  • galicin
  • galicin's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 4
  • Thank you received: 0
Hi!
There are a few imperfections with the plugin.
1. When you click add to cart on the category page, the effect is applied to the images of all products.
2. The "jswing" transition does not exist, that's right - "swing".
3. After scrolling the page, if the cart has a fixed positioning, the product image moves past the cart.
Fixes:
1. File vmaddtocarteffectck.php line 69
var imgtodrag = $('.".$categorycontainerclass." img.".$categoryimageclass."');
change to
var imgtodrag = el.closest('.".$categorycontainerclass."').find('img.".$categoryimageclass."');
2. File vmaddtocarteffectck.xml line 33
<option value="jswing">jswing</option>
to
<option value="swing">swing</option>
3. File vmaddtocarteffectck.php line 60
add (if fixed position cart, then when scrolling, the position of the cart changes relative to the top of the page )
$(window).scroll(function () {
vmcartck.top = vmcartck.offset().top;
vmcartck.left = vmcartck.offset().left;
})
Attachments:

Please Log in or Create an account to join the conversation.

Last edit: by galicin.

VM addToCart CK fix 22 Jul 2020 18:59 #57263

  • ced1870
  • ced1870's Avatar
  • Offline
  • Administrateur
  • Administrateur
  • Posts: 23798
  • Karma: 427
  • Thank you received: 2984
Hi
thank you for your effort and sharing the solution :)
I will check that and let you know soon
CEd
Joomlack Webmaster and Developer

Please Log in or Create an account to join the conversation.

VM addToCart CK fix 24 Jul 2020 06:03 #57294

  • ced1870
  • ced1870's Avatar
  • Offline
  • Administrateur
  • Administrateur
  • Posts: 23798
  • Karma: 427
  • Thank you received: 2984
can you please confirm which version of Joomla and Virtuemart you are using with the plugin ?
Joomlack Webmaster and Developer

Please Log in or Create an account to join the conversation.

VM addToCart CK fix 28 Jul 2020 19:24 #57345

  • galicin
  • galicin's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 4
  • Thank you received: 0
Joomla 3.9.20
Virtuemart 3.4.2
php 7.3

Please Log in or Create an account to join the conversation.

Last edit: by galicin.

VM addToCart CK fix 29 Jul 2020 06:58 #57349

  • ced1870
  • ced1870's Avatar
  • Offline
  • Administrateur
  • Administrateur
  • Posts: 23798
  • Karma: 427
  • Thank you received: 2984
thank you
I'm checking but I don't have the same line number as you .. can you please send me the whole ZIP of your plugin version ? so that I can compare
I will the update it on joomlack.fr so that other people can download it
Joomlack Webmaster and Developer

Please Log in or Create an account to join the conversation.

VM addToCart CK fix 29 Jul 2020 08:16 #57351

  • galicin
  • galicin's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 4
  • Thank you received: 0
Hi!
plg_vmaddtocarteffectck_1.1.0_j25.zip
If you mean line 60, it is empty in the plugin.
Simply put, you need to change lines 58-59
vmcartck.top = vmcartck.offset().top;
vmcartck.left = vmcartck.offset().left;
to
vmcartck.top = vmcartck.offset().top;
vmcartck.left = vmcartck.offset().left;
$(window).scroll(function () {
vmcartck.top = vmcartck.offset().top;
vmcartck.left = vmcartck.offset().left;
})
or, as I suggested earlier, add to line 60
$(window).scroll(function () {
vmcartck.top = vmcartck.offset().top;
vmcartck.left = vmcartck.offset().left;
})
In the first post, I attached an archive with files that require fix. You can compare plugin files with archive files.

Please Log in or Create an account to join the conversation.

Last edit: by galicin.

VM addToCart CK fix 03 Aug 2020 12:35 #57431

  • ced1870
  • ced1870's Avatar
  • Offline
  • Administrateur
  • Administrateur
  • Posts: 23798
  • Karma: 427
  • Thank you received: 2984
thank you ! I misse the files in the 1st post ;)
I have now added your modifications in a J3 version available here
www.joomlack.fr/en/download-joomla-exten...-addtocart-effect-ck
Joomlack Webmaster and Developer
The following user(s) said Thank You: galicin

Please Log in or Create an account to join the conversation.

VM addToCart CK fix 03 Aug 2020 12:56 #57432

  • galicin
  • galicin's Avatar Topic Author
  • Offline
  • Fresh Boarder
  • Fresh Boarder
  • Posts: 4
  • Thank you received: 0
Thank you!))

Please Log in or Create an account to join the conversation.

  • Page:
  • 1
Time to create page: 0.191 seconds

Fast and powerful creation, customizable and responsive.

Read More

Qui est en ligne

We have 175 guests and one member online