Warnings when using Accordeon Menu ck
Replied by ced1870 on topic Warnings when using Accordeon Menu ck
Posted 8 years 4 months ago #30850
ok, please remind me tomorrow because I have to go now. I will check why this happens now in the joomla 3.4.5
Joomlack Webmaster and Developer
by ced1870
Please Log in or Create an account to join the conversation.
Ok I will post again tomorrow morning. Thank you very much for your time!
by jrjr
Please Log in or Create an account to join the conversation.
Hi, have you had a chance to think about this any more?
by jrjr
Please Log in or Create an account to join the conversation.
I have to leave so please let me know. Will be back in around 6 hours or so.
by jrjr
Please Log in or Create an account to join the conversation.
Replied by ced1870 on topic Warnings when using Accordeon Menu ck
Posted 8 years 4 months ago #30887
I have check the file in Joomla 3.4.5
ibraries/cms/module/helper.php on line 225 and 242
around line 225 :
in my module I call the function like this
so attribs is defined and the line 225 shall not be executed, then even if it does not exists, the line 225 is explicite and force the variable to be created. I don't understand this warning and I wonder if this is really coming from my module. Yes if you are using the accordeon module and loading another module in it you will call this function, but this is the joomla core.
Then I can not reproduce this issue by my side using joomla! 3.4.5 ...
ibraries/cms/module/helper.php on line 225 and 242
around line 225 :
Code:
// Make sure a style is set
if (!isset($attribs['style']))
{
$attribs['style'] = 'none';
}
Code:
$attribs['style'] = 'none';
...
JModuleHelper::renderModule($module, $attribs);
so attribs is defined and the line 225 shall not be executed, then even if it does not exists, the line 225 is explicite and force the variable to be created. I don't understand this warning and I wonder if this is really coming from my module. Yes if you are using the accordeon module and loading another module in it you will call this function, but this is the joomla core.
Then I can not reproduce this issue by my side using joomla! 3.4.5 ...
Joomlack Webmaster and Developer
by ced1870
Please Log in or Create an account to join the conversation.
I found the cause finally.
I have are 2 menus using the accordeon modules. One created the errors and one did not. I unpublished all menu items in the one creating the warnings and the warnings went away. Then I published each link one by one. One menu item was causing the warnings. This menu item was an external url and opened a .pdf file in a new window without navigation. If I changed that to new window with navigation or parent, it does not create the warnings. I can live with new window with navigation. Just thought I would let you know my findings.
I had another issue unrelated to your module that appeared with the php upgrade that was related to a plugin called simplepopup. This was cured by unpublishing the plug in. I wasn't using it any longer anyway. There was another one with ossecure as well that I had already fixed. No more warnings or errors now!
Thank you very much for looking into this. If you would like any more info on the issue that I had let me know and I would be happy to test or help in any way that I can.
I have are 2 menus using the accordeon modules. One created the errors and one did not. I unpublished all menu items in the one creating the warnings and the warnings went away. Then I published each link one by one. One menu item was causing the warnings. This menu item was an external url and opened a .pdf file in a new window without navigation. If I changed that to new window with navigation or parent, it does not create the warnings. I can live with new window with navigation. Just thought I would let you know my findings.
I had another issue unrelated to your module that appeared with the php upgrade that was related to a plugin called simplepopup. This was cured by unpublishing the plug in. I wasn't using it any longer anyway. There was another one with ossecure as well that I had already fixed. No more warnings or errors now!
Thank you very much for looking into this. If you would like any more info on the issue that I had let me know and I would be happy to test or help in any way that I can.
Last Edit:8 years 4 months ago
by jrjr
Last edit: 8 years 4 months ago by jrjr.
The following user(s) said Thank You: ced1870
Please Log in or Create an account to join the conversation.
Time to create page: 0.711 seconds